Kobi Levi

Results 36 comments of Kobi Levi

> Hi @levikobi, it'd be great if you want to pick this one 👍 sure mate

> Thanks @camperjett ! > > Thinking about this more, `ingresses-only` is a bit different than not doing providers specific logic. Provider specific logic should be looking at specific ingresses...

OK, makes sense

Hi @davinkevin, I guess the resources in your `ingress.yaml` file do not specify a namespace (and if they do, it isn't the default one). Please use -A (--all-namespaces) flag. It...

@davinkevin are you sure you're using release 0.2? I can't seem to reproduce the error you're showing here TBH.. Neither on main

> hey @levikobi suggest running `make testdata`, this change probably ends up updates a bunch of golden yamldata Thank you for your review @arkodg! I addressed your comments, `make testdata`...

> @levikobi your changes might have affected e2e runs Apparently the `SupportedFeatures` list has a kubebuilder validation that checks for a hard-coded list of features (see [here](https://github.com/kubernetes-sigs/gateway-api/blob/main/apis/v1/gatewayclass_types.go#L269). The supported features...

The issue around the list of supported features is solved upstream via https://github.com/kubernetes-sigs/gateway-api/pull/2754 so I believe the tests should pass now. @arkodg can you please trigger another run?

> @levikobi dont we need to wait for a gateway-api release that has the change in CRDs ? currently pinned to v1.0.0 > > https://github.com/envoyproxy/gateway/blob/f21f9ff6590a8d52c1366ea0aa60228811711378/go.mod#L46 Definitely, my bad