envoyproxy
feat: add supported features to gateway class
What type of PR is this?
feat: add supported features to gateway class.
What this PR does / why we need it: This PR implements GEP-2162, which is about adding a list of supported features to the status of the gateway class.
hey @levikobi suggest running make testdata, this change probably ends up updates a bunch of golden yamldata
hey @levikobi suggest running
make testdata, this change probably ends up updates a bunch of golden yamldata
Thank you for your review @arkodg!
I addressed your comments, make testdata also seems to work now locally.
@levikobi your changes might have affected e2e runs
Apparently the SupportedFeatures list has a kubebuilder validation that checks for a hard-coded list of features (see here.
The supported features I took from the conformance suite contain features that aren't part of this list, which makes the update fail. That's why only e2e fails and not unit tests.
I saw that Cillium hard-coded their list of supported features. I'll dig around to see what others have done to develop a proper solution. @arkodg If you have any preferences, please let me know.
The issue around the list of supported features is solved upstream via https://github.com/kubernetes-sigs/gateway-api/pull/2754 so I believe the tests should pass now. @arkodg can you please trigger another run?
@levikobi dont we need to wait for a gateway-api release that has the change in CRDs ? currently pinned to v1.0.0 https://github.com/envoyproxy/gateway/blob/f21f9ff6590a8d52c1366ea0aa60228811711378/go.mod#L46
@levikobi dont we need to wait for a gateway-api release that has the change in CRDs ? currently pinned to v1.0.0
https://github.com/envoyproxy/gateway/blob/f21f9ff6590a8d52c1366ea0aa60228811711378/go.mod#L46
Definitely, my bad
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
I think a release should be out relatively soon (1-2 weeks from now). I suggest you keep an eye on it and merge after the release is out
I think a release should be out relatively soon (1-2 weeks from now). I suggest you keep an eye on it and merge after the release is out
Waiting for this release. Once it's out, I'll update this PR (rebase + the change you suggested @LiorLieberman)
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!
@levikobi i think rc1 is out. 1.1 should be out soon after we get feedback on the rc
@levikobi i think rc1 is out. 1.1 should be out soon after we get feedback on the rc
Thanks @LiorLieberman I rebased and resolved the opened comments. Once the release is out we should be ready to finish things up here.
LGTM thanks !
we probably need a follow up to decide whether this is opt in / opt out or always on once we gather more feedback from users
Thanks for the multiple reviews @arkodg! I'm in for the follow up
