Levi Buzolic

Results 33 comments of Levi Buzolic

``` javascript hourNode.addEventListener("click", selectOtherCellsInRow(index, selectedIndex, hourNode), true); ``` That doesn't run `selectOtherCellsInRow` on click, that will run the **result** of `selectOtherCellsInRow` on click. Which my guess isn't what you want....

To try and explain this a little better, take this example: ``` javascript someFunction = function(){ alert('Called'); }; node.addEventListener( 'click', someFunction ); // This will alert every time the node...

One thing to note is that this may not fix your race condition, but race-condition-or-not with the way you're calling the function currently it's never going to work as expected.

I'll try running the code locally tomorrow and take a proper look. There were a few things I saw earlier that could be tidied up, but I'll have to run...

Tested locally and looks to be working well. @dbalatero any chance you could merge this and publish a new release?

@davewasmer @zetlen 🙏 any chance this could get merged and a new patch release published? The [previous attempt](https://github.com/davewasmer/devcert/pull/66) at this has been sitting around for a while.

This fix works except it then causes issues with using `react-dom/server` ``` ERROR in Error: Cannot find module "react-dom/server" at webpackMissingModule (webpack:///./html.js?:12:79) at Object.eval (webpack:///./html.js?:12:172) at eval (webpack:///./html.js?:114:30) at Object../html.js...

This is largely going to be on the React Native packager end, rather than anything to do with `npx-visualize-bundle` or the library it uses `source-map-explorer`. These unmapped bytes can be...

Sounds related to #102 we’re still working on a fix.