Leroy Baeyens

+1 for nested hincludes!

Seems like that function is being used as constructor. Maybe refactor it to be like this ``` function hinclude(){ // code from addDOMLoadEvent } hinclude.prototype = { ... } ```

Maybe a `template` and an `engine` attribute can be added, that `template` attribute wil be the DOM identifier where to find the template itself. And the `engine` will be which...

I've come up with a different approach by using `MappingOperations`, because I like to map A relation's id or other attribute to a Dto's scalar value. For example, a Shop...

This should do the trick, I use this often and it's something like how Symfony does it. `$content` contains the complete configuration array! ```php if(isset($content['parameters'])){ foreach($content['parameters'] as $param){ foreach($param as...

The `mobile_detect.device_view` service is a private service, which causes a deprecation notice because getting private services wil fail in symfony 4. I prefer adding the `isMobileView()` etc. methods to the...

Most of the time the root user is a management user only, and is only allowed to connect from localhost. Make sure you are using the right database_host. This has...

Add the ssl related section to the nginx conf. Just an example: ``` listen 443 default_server ssl; ssl_certificate /etc/nginx/ssl/cert.pem; ssl_certificate_key /etc/nginx/ssl/cert.key; ``` And add a default self-signed certificate for symfony.dev....

You could also only implement the WriterInterface, and implement both new classes. So both Formatters and Writers can be considered final classes. ```php final class CsvWriter implements WriterInterface { private...

@kshitij241 's answer worked, but installs the openshift v4 client. Some things like flags are removed or replaced, keep that in mind!