Léon Gersen

Results 53 comments of Léon Gersen

I noticed the "missing" resource name when creating a reproducer for the empty array in `languageConstants`, so that might not be an issue.

I also just ran into this when trying to clear a bid on `AdGroupCriterion`. `setCpcBidMicros` cannot be called with `null`, and calling `clearCpcBidMicros` does not result in `cpc_bid_micros` appearing in...

Sure: ```php $adGroupCriterion = new AdGroupCriterion(); // This should be valid, as clearing the bid on a criterion is a valid operation $adGroupCriterion->setCpcBidMicros(null); // Fails, "Uncaught Exception: Cannot convert ''...

I just ran into another example of this problem. In the AdWords API, it was possible to [clear an existing bid modifier by setting its value to `-1`](https://github.com/googleads/googleads-php-lib/blob/e6f22234b50c661ab9235bbd5360d711f5562768/resources/wsdls/api/adwords/cm/v201809/CampaignCriterionService.wsdl#L375). In the...

Good observation, I'll get it fixed. Thanks!

`1234567890123456` is smaller than `Number.MAX_SAFE_INTEGER`, the other examples are larger. There's not a lot that can be done about this, I'm afraid.

That would probably be a good idea. The limit is a limitation of the language, not the library. I'll add it to the docs.

I'm not entirely sure what you'd like to do here, but if I understand it correctly you could implement this by using the `decoder` option (which applies before all other...

I'm assuming you've updated to [15.5.0 or later](https://github.com/leongersen/noUiSlider/blob/master/CHANGELOG.MD#1550-2021-09-01). Your custom styles will need updating. [These changes in the default stylesheet](https://github.com/leongersen/noUiSlider/commit/a1f8f17fa7a2a2ea81a8f9a4fd7c4692ebe16927) need to be incorporated in your overriding styles. See #1167...

No, if you override the included styles you'll have to keep them compatible. The break change here is unfortunate, and I would've avoided it in hindsight. Again, see #1167 for...