Leonardo Villela

Results 18 comments of Leonardo Villela

> What is the expected behavior if the new and old module do not match in global or scope? Hi @joebowbeer I didn't understand your question, can you provide an...

All commits that I will push here trough the review will be squashed in the end, before merge the PR 😉

> can you please test this feature with the following use cases: > > ```ts > import { Module, Injectable, DynamicModule, forwardRef } from '@nestjs/common'; > import { LazyModuleLoader }...

> @leonardovillela my question is what is supposed to happen if the replacement module has a different global setting than the module it is replacing? Similarly, what if scope settings...

> @leonardovillela my question is what is supposed to happen if the replacement module has a different global setting than the module it is replacing? Similarly, what if scope settings...

Hi @micalevisk, today I finally finished adding the samples and during this process. I also saw that the override was not working properly(e.g: lazy loaded modules) for some use-cases and...

> I believe you forgot to push the source codes > > ![image](https://user-images.githubusercontent.com/13461315/146684463-e599a9e1-bdbe-4a0d-8c72-8ae78871e0f1.png) @micalevisk sorry, now is fixed 😅😅 🤦‍♂️🤦‍♂️🤦‍♂️

> Instead of adding a new sample, we should cover this functionality in the integration tests. Done in https://github.com/nestjs/nest/pull/8777/commits/91d487032356ba61d4794a8d4cbd4fcd014f570d. @kamilmysliwiec please let me know what do you think.

> @leonardovillela from your experience on implementing this, do you mind taking a look at `.overrideMiddleware` proposal from `https://github.com/nestjs/nest/issues/4073` I would like to know if you believe that one shouldn't...

@kamilmysliwiec is there something that I can do to help in the review process?