leonardo-albertovich
leonardo-albertovich
Awesome, I'll take a look at it since I wrote that code, I think I have some ideas as to what could be the issue but I need to validate...
Thanks for staying on top of it @dekimsey, I still haven't been able to take a look at it, I know what the issue in the mechanism is and have...
You are right @dekimsey, that is a work in progress but sadly we weren't able to include it in 2.0. I've added the `exempt-stale` label to this issue so it...
Thanks for the comments you've addressed so far, I'm taking a lunch break and I'll review your changes afterwards. I wanted to mention that I stopped commenting on the initialization...
> Also, I've noticed that the macos test check is running for over 5 hours? Is that normal? I don't think any of these taking hours is normal, did you...
I think there's a fix in master for that macos test issue, I'd suggest rebasing.
I don't think any of the CI issues are relevant to this PR. From my point of view this is mergeable.
As far as I know those are some pretty popular plugins so I don't see the change really taking off unless those plugins are compatible and operational.
We'll probably want to tweak the debug messages at some point but as far as the code goes this is good, thanks, let's see what CI thinks and if everything...
That's up to @edsiper, I approved the PR with the condition that tests passed and they did, I'll remind him about it today.