fluent-bit icon indicating copy to clipboard operation
fluent-bit copied to clipboard

out_es: resolve domain name not found issue in cloud_id as it contains a port.

Open 030 opened this issue 3 years ago • 8 comments

Complete unfinished work in PR https://github.com/fluent/fluent-bit/issues/3920 Ticket: #4260

…g cloud_id.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing Before we can approve your change; please submit the following in a comment:

  • [N/A] Example configuration file for the change
  • [x] Debug log output from testing the change
[2022/05/16 07:53:42] [ info] [cmetrics] version=0.3.1
[2022/05/16 07:53:42] [debug] [output:es:es.0] extracted cloud_host: 'xyz.westeurope.azure.elastic-cloud.com:9243'
[2022/05/16 07:53:42] [debug] [output:es:es.0] check whether extracted cloud_host 'xyz.westeurope.azure.elastic-cloud.com:9243' contains a port
[2022/05/16 07:53:42] [debug] [output:es:es.0] cloud_host without port: 'xyz.westeurope.azure.elastic-cloud.com'
[2022/05/16 07:53:42] [debug] [output:es:es.0] extracted portChar: '9243'
[2022/05/16 07:53:42] [debug] [output:es:es.0] converted portChart to port int: '9243'
[2022/05/16 07:53:42] [debug] [output:es:es.0] checked whether extracted port was null and set it to default https port or not. Outcome: '9243'
[2022/05/16 07:53:42] [debug] [output:es:es.0] host=xyz.westeurope.azure.elastic-cloud.com port=9243 uri=/_bulk index=pega-bix-logs-tip-acc type=_doc
[2022/05/16 07:53:42] [ info] [sp] stream processor started

  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [ ] Attached local packaging test output showing all targets (including any new ones) build.

Documentation

  • [N/A] Documentation required for this feature

Backporting

  • [N/A] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

030 avatar May 16 '22 07:05 030

@nokute78 Could you review the PR please?

030 avatar May 23 '22 07:05 030

Related: #3923

030 avatar May 23 '22 07:05 030

@PettitWesley and @edsiper Could you review the PR please?

030 avatar May 23 '22 07:05 030

@nokute78 thank you for reviewing. The feedback has been processed (SIGSEGV issue resolved) and the logging looks as follows now:

[2022/06/12 16:32:31] [debug] [output:es:es.1] extracted cloud_host: 'cec6f261a74bf24ce33bb8811b84294f.us-east-1.aws.found.io'
[2022/06/12 16:32:31] [debug] [output:es:es.1] check whether extracted cloud_host 'cec6f261a74bf24ce33bb8811b84294f.us-east-1.aws.found.io' contains a port
[2022/06/12 16:32:31] [debug] [output:es:es.1] cloud_host without port: 'cec6f261a74bf24ce33bb8811b84294f.us-east-1.aws.found.io'
[2022/06/12 16:32:31] [debug] [output:es:es.1] extracted cloud_port_char: '(null)'
[2022/06/12 16:32:31] [debug] [output:es:es.1] checked whether extracted port was null and set it to default https port or not. Outcome: '443'
[2022/06/12 16:32:31] [debug] [output:es:es.1] host=cec6f261a74bf24ce33bb8811b84294f.us-east-1.aws.found.io port=443 uri=/_bulk/?pipeline=pega_pipeline index=pega-cluster-logs-tip-dev type=_doc
[2022/06/12 16:32:31] [ info] [output:es:es.0] worker #0 started
[2022/06/12 16:32:31] [ info] [output:es:es.0] worker #1 started

030 avatar Jun 12 '22 16:06 030

@nokute78 I will rebase and let you know when that is done.

030 avatar Jun 12 '22 16:06 030

@nokute78 Rebased. Could you review again please?

030 avatar Jun 12 '22 16:06 030

@nokute78 Processed the feedback and the Windows CI succeeded now. Could you review again please?

030 avatar Jul 19 '22 14:07 030

@nokute78 rebased. Could you review again please?

030 avatar Aug 08 '22 09:08 030

Note: CIFuzz failed because of current master. See also https://github.com/fluent/fluent-bit/issues/5876 .

nokute78 avatar Aug 12 '22 04:08 nokute78

@nokute78 Thank you. Could you indicate when this PR will be merged into master?

030 avatar Aug 14 '22 09:08 030

@edsiper @niedbalski Could you merge this pull request ?

nokute78 avatar Aug 18 '22 11:08 nokute78

@niedbalski @nokute78 Could you indicate when this PR will be merged?

030 avatar Aug 21 '22 11:08 030

@nokute78 @niedbalski @edsiper Rebased again. Could somebody approve again and merge?

030 avatar Aug 30 '22 14:08 030

@nokute78 @niedbalski @edsiper Rebased. Could somebody approve again and merge?

030 avatar Sep 03 '22 09:09 030

@nokute78 @niedbalski @edsiper Rebased again.

030 avatar Sep 05 '22 08:09 030

@nokute78 @PettitWesley @edsiper @leonardo-albertovich @fujimotos @koleini Rebased again. Could somebody reapprove again and finally merge?

030 avatar Sep 07 '22 07:09 030

We'll probably want to tweak the debug messages at some point but as far as the code goes this is good, thanks, let's see what CI thinks and if everything goes well it can be merged in my opinion @edsiper

leonardo-albertovich avatar Sep 14 '22 18:09 leonardo-albertovich

@leonardo-albertovich Thank you for approving. Can you please merge this PR finally?

030 avatar Sep 15 '22 07:09 030

That's up to @edsiper, I approved the PR with the condition that tests passed and they did, I'll remind him about it today.

leonardo-albertovich avatar Sep 15 '22 07:09 leonardo-albertovich