Leonardo Luz Almeida
Leonardo Luz Almeida
@wmgroot Any reason why pointing this PR to the `release-2.4` branch? I think it should point to `master`.
> I also tried our service port case mentioned in [#8812 (comment)](https://github.com/argoproj/argo-cd/pull/8812#discussion_r849140565) but unfortunately, it doesn't work and threw error during diff phase. The error is: > >  >...
> I was using the same manifest but I still got this error. No duplicate port name. Can you pls try applying this manifest and provide me the results? ```yaml...
@yeya24 I rebased this branch with master, deployed locally and tested with https://github.com/argoproj/argo-cd/pull/8812#discussion_r849140565 and confirm that its working as expected. Can you please try again with this updated branch? Btw,...
@IgorGee Tks for the `Shift + up/down` tip! I guess I'll go with it instead of hacking the command to add the `--bind` to fzf. It would be great if...
@huikang We are thinking about cutting the 1.3-rc1 and this PR is listed in 1.3 milestone. Would you be able to address @zachaller 's comments so we can merge and...
@huikang Approved but there is a unit-test failing now. Can you pls take a look so I can merge? ``` === FAIL: pkg/kubectl-argo-rollouts/cmd/get TestGetAbortedRollout (0.11s) get_test.go:560: Error Trace: /home/runner/work/argo-rollouts/argo-rollouts/pkg/kubectl-argo-rollouts/cmd/get/get_test.go:26 /home/runner/work/argo-rollouts/argo-rollouts/pkg/kubectl-argo-rollouts/cmd/get/get_test.go:560...
@Sudhamsh Thanks for your contribution. I am willing to merge this PR but I need you to please sign-off your commit. In order to do so, just follow the directions...
It seems that `rollout_info` and `rollout_phase` are [const metrics](https://github.com/argoproj/argo-rollouts/blob/55a041a6b3d088cf9ddcfc4121ad8c97880489db/controller/metrics/rollouts.go#L128) which means that their [value don't change](https://pkg.go.dev/github.com/prometheus/client_golang/prometheus#NewConstMetric). In this case we probably want to create a new CounterVec metric to collect...