leofvo

Results 28 comments of leofvo

It seems the action aren't triggered, I suggest to check in repository settings https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#enabling-workflows-for-forks-of-private-repositories

@urbanadventurer what do you think about this improvement ?

Hey, I'm also looking for csv support. It could be awesome to allow custom separator.

Hey, I wrote a proposal for this feature, feel free to review and merge if it's fine for you !

@EgeAytin 👋 Any updates ?

Hey, this PR is fixing some issues I noticed [here](https://github.com/falcosecurity/falco-talon/issues/491) I also improved the codebase to be more uniformized with falco charts. If you have any questions, feel free to...

> I'm not sure, I understand the reason here. `/wait-for-it.sh` (the only command in `wait-for-db` container) is testing only TCP connection. It is not trying to log in to the...

I removed the unused database password and pointed to dev branch. Feel free to squash if required.

I just noticed that the job doesn't have helm hook (https://helm.sh/docs/topics/charts_hooks/). I think we should consider adding: ```yml "helm.sh/hook": pre-install, pre-upgrade "helm.sh/hook-delete-policy": hook-succeeded ``` This will make the job run...

Agree, this has to be done in this PR or another one ?