charts icon indicating copy to clipboard operation
charts copied to clipboard
verified publisher icon falcosecurity

Refactor falco talon chart

Open leofvo opened this issue 1 year ago • 5 comments

What type of PR is this? /kind cleanup /kind feature /kind chart-release

Any specific area of the project related to this PR? /area falco-talon

What this PR does / why we need it: I added support of name and namespace override for falco-talon as Falco is doing. I added support for falco-talon custom rules. I found an issue that i wasn't able to custom talon rules due to a little mistake in the chart, after discussion with a maintainer, we have agreed to change this behavior to support it as Falco does.

Which issue(s) this PR fixes: Fixes #https://github.com/falcosecurity/falco-talon/issues/491#issuecomment-2414710722

Special notes for your reviewer: This is my first contribution to Falco, don't hesitate to give me feedbacks if I can improve my proposals.

Checklist

  • [x] Chart Version bumped
  • [x] Variables are documented in the README.md
  • [x] CHANGELOG.md updated

leofvo avatar Oct 15 '24 20:10 leofvo

@LeoFVO: The label(s) area/falco-talon cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this? /kind cleanup /kind feature /kind chart-release

Any specific area of the project related to this PR? /area falco-talon

What this PR does / why we need it: I added support of name and namespace override for falco-talon as Falco is doing. I added support for falco-talon custom rules. I found an issue that i wasn't able to custom talon rules due to a little mistake in the chart, after discussion with a maintainer, we have agreed to change this behavior to support it as Falco does.

Which issue(s) this PR fixes: Fixes #https://github.com/falcosecurity/falco-talon/issues/491#issuecomment-2414710722

Special notes for your reviewer: This is my first contribution to Falco, don't hesitate to give me feedbacks if I can improve my proposals.

Checklist

  • [ ] Chart Version bumped
  • [ ] Variables are documented in the README.md
  • [ ] CHANGELOG.md updated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

poiana avatar Oct 15 '24 20:10 poiana

Welcome @LeoFVO! It looks like this is your first PR to falcosecurity/charts 🎉

poiana avatar Oct 15 '24 20:10 poiana

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LeoFVO Once this PR has been reviewed and has the lgtm label, please assign cpanato for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

poiana avatar Oct 15 '24 20:10 poiana

Hey, this PR is fixing some issues I noticed here

I also improved the codebase to be more uniformized with falco charts. If you have any questions, feel free to ask :)

leofvo avatar Oct 15 '24 20:10 leofvo

I'm currently in Norway for a talk, will review asap. Thanks a lot.

Issif avatar Oct 16 '24 09:10 Issif

Hi,

For releasing the v0.2.0 we updated the charts and took some of your ideas, I let you test it and tell us your feedback, thanks. Feel free to close this issue then.

Issif avatar Dec 09 '24 11:12 Issif

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana avatar Mar 09 '25 16:03 poiana