Lens0021 / Leslie
Lens0021 / Leslie
This is not a complex PR. Can I reassign this to myself?
https://github.com/amber-lang/amber/blob/e25d356f423ac503275c29185e9a04a8acc05e98/src/std/text.ab#L265-L274 This also is problematic since it is not using `nameof text`. Could you look into this?
> Having functions `bash_version_is_greater_than` and `bash_version_is_less_than` seems clunky, where array comparison operators are more intuitive: > > ``` > if bashver >= [5, 2, 21, 1] { > } >...
Thank you for filling this ticket! The compatibility should always be the first class.
Are https://github.com/amber-lang/amber/issues/83 and https://github.com/amber-lang/amber/issues/142 resolved?
Blocking the fix of this issue until implementing a new feature seems as an overkill to me. Isn't a quick fix needed?
Yes, that is shorter. 👍
I think it should expose the fix version as well as the major and the minor.
I have not known the fourth one! Well, how about supporting `bash_version_is_greater_than([5, 2, 21, 1])` and `bash_version_is_less_than([5, 2, 21, 1])` calls?
Or string as argument and supporting all the following, etc? ``` bash_version_is_greater_than("5.2.21(1)") bash_version_is_less_than("5.2.21(1)") bash_version_is_less_than("5.2.21.1") bash_version_is_less_than("5.2.21") bash_version_is_less_than("5.2") bash_version_is_less_than("5") ```