Amber icon indicating copy to clipboard operation
Amber copied to clipboard
verified publisher icon Ph0enixKM

[BUG] Bad escaping for a string with \$ sequence #593

Open Ph0enixKM opened this issue 1 year ago • 4 comments

This fixes #593 and relies on https://github.com/amber-lang/amber/pull/592 so until it's not merged, the pipeline will fail.

Blocked by #592

Ph0enixKM avatar Nov 14 '24 18:11 Ph0enixKM

@Ph0enixKM requires an update this PR

Mte90 avatar Apr 10 '25 09:04 Mte90

Btw, you can add Blocked by #592 to the description so it is properly marked by GitHub.

ArjixWasTaken avatar Apr 10 '25 10:04 ArjixWasTaken

I've updated the description. @ArjixWasTaken where does GitHub mark this PR as blocked?

Ph0enixKM avatar Apr 12 '25 09:04 Ph0enixKM

Right now doesn't fail, something that got fixed in the meantime? It is still needed?

Mte90 avatar Apr 16 '25 10:04 Mte90

This is not a complex PR. Can I reassign this to myself?

lens0021 avatar Jul 07 '25 11:07 lens0021

@lens0021 Sorry I just read your comment. I've already fixed my branch. Could you review this PR?

Ph0enixKM avatar Jul 09 '25 09:07 Ph0enixKM

https://github.com/amber-lang/amber/blob/e25d356f423ac503275c29185e9a04a8acc05e98/src/std/text.ab#L265-L274

This also is problematic since it is not using nameof text. Could you look into this?

lens0021 avatar Jul 09 '25 09:07 lens0021

@lens0021 good catch! Fixed it

Ph0enixKM avatar Jul 09 '25 10:07 Ph0enixKM