Daniel Lenksjö

Results 76 comments of Daniel Lenksjö

Thanks for your comments. I can see your point of view more clearly. > I cannot think of a situation where leaving the optional property there gets in the way...

Hi @custompro98. Sorry for late reply. Yeah, it seems like a good idea from a type safety perspective. However, this code is generated from the spec https://raw.githubusercontent.com/rabbitmq/rabbitmq-codegen/main/amqp-rabbitmq-0.9.1.json (also available in...

Update: I thought a bit more about this and I think the main benefit is to make it easier to publish dev versions automatically. However, I have second thoughts about...

Also, if we were to pull https://github.com/WebOfTrust/keria/commit/caad67b629827659fd7a6fc0c961563633968d1d and patch 0.1.x of keria, we could merge this without having to upgrade to keria 0.2.x.

@daviddm @2byrds I have rebased the branch and re-ran the test, it passes now.

> > @daviddm @2byrds I have rebased the branch and re-ran the test, it passes now. > > Excellent! Can it be merged @lenkan ? Yes, just wanted to await...

I tried fixing that line and run against a local keria image, then it resolves. https://github.com/WebOfTrust/keria/pull/236

When the test [here](https://github.com/WebOfTrust/signify-ts/pull/258) passes, we can merge that and this issue is resolved. Currently that test is failing because it the KERIA images is not updated to include the...

@2byrds Yes, thanks for notifying.

@rodolfomiranda There is something wrong after the upgrade to 0.2.0-dev0. I tried to debug the multisig-vlei test and found that after the client of GAR1 resolves the oobi for the...