Luis Enrique Muñoz Martín

Remove `ProxyType` code duplication

2

# Description Currently, we have around 200 lines around `ProxyType` of critical code exaclty copied in all runtimes. An oversight on this could open a hole in the chain's security,...

Internal dependencies organization

15

# Description We don't have well-defined rules about where things should be. Here I propose some changes and rules that I think can improve the repo organization and get rid...

### Description Consider using the new macro for amalgamating enums for `RuntimeChange`: [`composite_enum`](https://paritytech.github.io/polkadot-sdk/master/frame_support/attr.pallet.html#composite-enum-palletcomposite_enum-optional) which would help to deal with this type when it's used in several places.

Loans: Unify errors in the pallet level

8

### Description Currently, we have split errors in `pallet-loans` depending on its type (see [here](https://github.com/centrifuge/centrifuge-chain/blob/b006fb86cd0a3121ffc2ec603436c7b678c81a4a/pallets/loans/src/types/mod.rs#L31)). Nevertheless, it's only because of code organization and the message is not containing the last...

### Description Weights for development are not used anymore and can be removed. Tasks - Remove the `runtime/development/src/weights` folder. - Adapt pallets in development runtime to use the default `WeightInfo`.

_Originally posted by @mustermeiszer in https://github.com/centrifuge/centrifuge-chain/pull/1443#pullrequestreview-1525940702_ * I do not really like using the `enum InterestRate` as a fixed type in the pallet and trait interface. Does not feel like...

I think we should remove this pallet all-together. We will not use it again. _Originally posted by @mikiquantum in https://github.com/centrifuge/centrifuge-chain/pull/1444#discussion_r1256071025_

### Description Depending on the internal mechanism used, retrieving the stake amount in an account is different. i.e. for the `base` mechanism is as simple as reading the `stake` property...

Use less heavy Rate type for Loans

6

### Description Once #1189 has been merged, all rates configured by `pallet-loans` are considered yearly and are not used for computations, so we do not need a `Rate` of 128...

Rewards: Move `PalletId` associated type to `Issuance`

1

### Description The only purpose of using `PalletId` in `pallet-rewards` was to mint from the pallet account. Since we now mint using the `RewardIssuance` trait, we should configure a `PalletId`...