Luis Enrique Muñoz Martín

### Which part of the code is the issue addressing? - Cleaning ### Description In https://github.com/centrifuge/centrifuge-chain/pull/978 we remove two storages: ```rust // Additional fee charged when transferring native tokens to...

## Currently There are a lot of tests where a call to an extrinsic that is expected to fail is checked as follows: ```rust assert_noop!( Pallet::my_extrinsic_call(), DispatchError::Module(ModuleError { index: 2,...

Mock builder: usage example for the auction's Leaser type

7

This PR shows some simplifications/improvements of using [mock-builder](https://reference.centrifuge.io/mock_builder/index.html) for mocking/testing pallets. @kianenigma @gavofyork @shawntabrizi @bkchr It's a response to a [Polkadot forum thread](https://forum.polkadot.network/t/mock-builder-a-utility-to-create-mock-pallets/2955/8?u=lemunozm). There's no intention to be merged.

Why not `checked_pow` as a trait method

1

Hi! This is only a design question about the current implementation of `checked_pow` as a function. Why is it implemented as a function instead of using a trait method as...

Oracles: `on_new_data()` improvements

9

Hi, As a user of `orml_oracle`, we've found some limitations regarding the `on_new_data()` callback when the oracle is fed: 1. `on_new_data()` should return a `DispatchResult`. A user could want to...

Oracle should use the `TimestampedValue` from `orml_traits`

4

Hi! Both `orml_oracle` and `orml_traits` define the same `TimestampedValue` struct. This is not an issue at all. Nevertheless, `orml_oracle` is using its own `TimestampedValue` as a requirement in `CombineData` and...

Support for combined values in OnNewData trait

3

Hi! As a user of `orml_oracle`, I miss the possibility of receiving callbacks when a combined value is updated. Currently, `orml_oracle` only calls `OnNewData::on_new_data()` with no combined values. It would...

Improve `append_extrinsic` to return a `DispatchResult`

4

Currently if an extrinsic fails, it returns a `()` as error, would be awesome to return a `DispatchResult` instead (not sure is it feasible)

Support generics in `fudge::companion` structs, as follows: ```rust #[fudge::companion] pub struct TestEnv { #[fudge::relaychain] pub relay: RelaychainBuilder, #[fudge::parachain(2000)] pub parachain: ParachainBuilder, } ``` This allows to create different `TestEnv` for...

IT: rewards to generic framework. Remove previous non-generic IT utilities

6

# Description Fixes https://github.com/centrifuge/centrifuge-chain/issues/1790 ## Changes and Descriptions - Block rewards tests ported to run under `generic` version. - **WARNING**. block rewwards now uses `Instance1` instead of `Instance2` in development...