Xianming Lei
Xianming Lei
[#1163] improvement(netty): return the direct byte buffer when getting localfile data by using netty
@pegasas In fact, this line of code in getShuffleData#transferTo method `channel.write(buffer.convertToNetty())` will use zero-copy api, we should keep using `FileSegmentManagedBuffer` instead of `NettyManagedBuffer`.
[#1163] improvement(netty): return the direct byte buffer when getting localfile data by using netty
> > @pegasas In fact, this line of code in getShuffleData#transferTo method `channel.write(buffer.convertToNetty())` will use zero-copy api, we should keep using `FileSegmentManagedBuffer` instead of `NettyManagedBuffer`. > > It looks like...
[#1163] improvement(netty): return the direct byte buffer when getting localfile data by using netty
@pegasas Are you willing to raise a PR to implement the zero-copy logic of Encoder? also there is another problem. At present, only sendShuffleData uses netty. The three interfaces getLocalShuffleData,...
[#1163] improvement(netty): return the direct byte buffer when getting localfile data by using netty
> > @pegasas Are you willing to raise a PR to implement the zero-copy logic of Encoder? also there is another problem. At present, only sendShuffleData uses netty. The three...
> Maybe we can make these parameters as default value. @leixm These config options are related to you. Could you raise three pull requests to modify them one by one?...