James Schloss
James Schloss
Could you elaborate on the bug a bit?
So I was looking at this today. There is definitely a bug in some implementations, but it is unclear what that is because the python code is radically different. We...
I agree. The only caveat is that we need to somehow ensure all output is the same. A hard-coded set is easier to do that with.
Yeah, this is what I was thinking. I mainly didn't want to limit the people who might be using julia / python / matlab / etc that have their own...
But maybe we should? I mean, a single data file to compare against might be a good idea in some cases. It's not like the data will be gigabytes in...
Yeah, alright. Let's put that on the list of things for me to do during Hacktoberfest (next month).
Ah, yeah. I remember this discussion now. Gale--Shapley was a bit of a different case, though. It wasn't meant to output actual data and there was nothing to plot. Still,...
I think I might have been against that case a while ago because we already had a few implementations for that method and I didn't want to go through and...
The reason these PR's take so long is that we don't have people who know the language (in this case ruby). On my end, it looks clean, so maybe I...
Yeah, it was just something to put out there. I don't think this is an easy fix.