Leif Gruenwoldt

Results 141 comments of Leif Gruenwoldt

Any of us happen to have a sample IFF Data PDU to use as reference to confirm ?

Hi @pulsebreaker thanks for the comment. Originally there were many instances of nulls in the code. There were more than I had time to fix all at once. So I've...

@pulsebreaker thank-you for the sample. This was very helpful. I made a large change to the Electromagnetic Emission Pdu parser/serializer and used your sample packet in a unit test. Can...

@pulsebreaker Ah Ok, I understand it now. Try it now I pushed a fix.

Great news @pulsebreaker Unrelated....Do you have other sample dis 7 packets you could share? I would add them to make our unit test coverage better.Any and all pdu types would...

@ztolley Yes there are still many null's in the code base left over from the auto generated code tool. Over time I've been fixing the most obvious ones. The most...

Thankyou @DuffyScottC . Would you like to submit a PR for this one too?

Thank-you for the report @kastork Setting the length seems like something that should be done automatically by the library. Can I interest you in submitting a pull request?

Here's an example for how length is calculated in open-dis-java https://github.com/open-dis/open-dis-java/blob/master/src/main/java/edu/nps/moves/dis/EntityStatePdu.java#L61

Thanks for the suggestion. This is just an example. But if it's useful for you please go ahead and implement the change, confirm it works and submit a pull request...