Leif Gruenwoldt

Results 141 comments of Leif Gruenwoldt

@wadehunk I've tagged a new release v1.0.1 that includes #78 . Over to you

@wadehunk I could be looking in the wrong spot but have you seen the open-dis-cpp appear in vcpkg yet? When I query for it I don't see it yet. https://vcpkg.io/en/packages.html

This should be fixed by the recently merged #76 I'm going to close this issue but reopen if you're still seeing an issue.

@wadehunk I would suggest we start with option 1. I don't like repeating code either, but there are not many changes to DataStream over time. And like you mentioned it'd...

Closing. PR #81 replaced OneByteChunk class with uint8_t.

We've just merged #73 . There's some similarity between this and that. And since this PR grew stale I'm going to close this PR. If any pieces of this PR...

A while back I fixed a number of occurences of null() in the code base that were causing issues. https://github.com/open-dis/open-dis-python/commit/99b7938a1a9c316dbec085b429d2539d3d4b25bb https://github.com/open-dis/open-dis-python/commit/10f241ed74b7e8f9cac4162f23059d49079e694d It looks like this one was missed.

Sure though I'm not sure None is the right replacement. Comparing this with the fix to the other null() fixes it looks like `element` needs to be initialized to a...

If the java implementation is right then iffData is an array of bytes. https://github.com/open-dis/open-dis-java/blob/master/src/main/java/edu/nps/moves/dis7/IFFData.java#L127

My hunch is it may need to be changed to this ```python for idx in range(0, self.recordLength): val = inputStream.read_byte() self.iffData[ idx ] = val ```