Max Cote

Results 8 comments of Max Cote

Thanks for the review @sohkai ! I applied the changes but somehow the Travis tests seems to fail now. I'm a bit perplexed since everything looks fine when I run...

@sohkai @bingen Sorry guys for the delay, we've been quite busy working on our demo for Aracon and the end of the Drive app milestone. I should be able to...

Currently looking into why one test is failing.

As for the gas usage sanity check, since the new functions are not used in aragonOS and are `internal`, there should be no impact on gas usage.

I will submit a pull request if you think it's a good idea

Sorry for the delay we were a little bit busy completing our first milestone hehe. I agree with @Quazia that maybe it would be a good idea to split this...

@sohkai @bingen I was about to add some tests for the new functions but I just noticed that the `ACLSyntaxSugar.sol` is in the skip list of [.solcover.js](https://github.com/aragon/aragonOS/blob/dev/.solcover.js#L4) Do you know...

Got it! Thanks for the explaination @sohkai ! ;)