Wu-Jung Lee

Results 268 comments of Wu-Jung Lee

Let's investigate this as part of the test overhaul in 0.6.4, but not delaying this further so that we can once and for all be happy that we don't have...

> ### Some open questions about the _fixed-location use case_, such as from a mooring > * What should the timestamp on the location be? eg, the first or last...

This one seems outdated now? @emiliom

> If we can't decide on which option is best, we could have a user input to `combine` that allows the user to choose which of the options above is...

@emiliom : a question for you: Currently we have `qc` as a subpackage that only contains checking and correcting for the monotonicity of the `ping_time` coordinate. But in this framing...

We discussed this briefly in the meeting today and there is a broader and a narrower interpretation of this: - narrow: there are changes that involve adding new variables, either...

Temporary fix? @lsetiawan will try to see if we can delay the function for now to allow this to run through. the lines that use xarray functions to do mean:...

Hey @dsmossman : Thanks for reporting this! What is the datatree version you have? In the requirements we pinned it at a pretty old version `xarray-datatree==0.0.6` so I wonder if...

> Would you also like me to make this same change of exposing `skipna` and using `func` under the hood to `compute_NASC`? Sounds good if you could add this for...

> In `compute_raw_NASC`, the operation change should only be in the setting of mean/nanmean in the `sv_mean = _groupby_x_along_channels(...,func=func="nanmean" if skipna else "mean",...)` right? Not sum/nansum? Since `sv_mean` and not...