Wu-Jung Lee

Results 268 comments of Wu-Jung Lee

Note from WGFAST 2022: Lars Anderson from Simrad now has python code implemented for these, so we can cross check and resolve this!

Note from working on #657 that when we get to this we can clean up the current use of `freq_center` as a selector for CW/BB waveform mode, since with the...

@emiliom : Thanks. Could you create an issue to make sure that we don't forget about that, and close this issue?

Notes while reviewing #685 as a reminder: Under `v05x_to_v06x._modify_sonar_group` we fill NaN to missing data. For cases like this, may be a good idea to have an overarching statement in...

I agree that the default chunking is not always necessary and probably makes performance worse in some cases. I think a good juncture to look into this is to consider...

Oh cool, thanks! Let me think through this and also read my own (undocumented) code...

Linking to https://github.com/OSOceanAcoustics/echopype/pull/808#discussion_r984074790 so that we remember to add explanation of how we correct for the reversed time in the documentation and link in the `combine_echodata` docstring.

@b-reyes and @leewujung discussed and identified the following to be resolved for `_clean_ping_time`: - `local_win_len` is necessary to estimate an approximate regular timestamp interval to correct for the reversal problem....