Sirui Li comments

Results 19 comments of


Sirui Li

Incompatible with @apollo/client 3.3.19?

older version works. but we need to update Apollo version. so this still needs to be fixed.

Fix fileName for android

could you explain why the file name will become `persist:pdfstorage`?

Can't declare variable with the same name as TypeScript type import

`@babel/[email protected]` doesn't solve the problem for me. Also we need higher version to resolve other issues.

feat: add velocity to spring animation

@ajsmth I added a parameter `velocityMultiplier` to control how much you want it to scroll. let me know if it works!

feat: add velocity to spring animation

updated the PR to work with v0.2

Major improvements and resolutions to most open issues.

this looks nice. any chance we can get this merged soon?

Android Intl doesn't work as expected

in my testing. default timezone in Intl is always `UTC`. this behaviour is different from the default `Date` timezone. ``` > time.toString() < Tue May 12 2020 22:00:00 GMT+0800 (HKT)...

Completion handler is not called

Looks great. I think the example project needs to be updated as well 👍🏼

Inconsistency between docs and example regarding completionHandler()

yes i've found the same issue. it's very confusing because `completionHandler` is supposed to be called.

Inconsistency between docs and example regarding completionHandler()

@apfritts i'm not familiar with iOS, but my understanding it that `completionHandler` should eventually be called (not necessarily in `AppDelegate`). is it correct? the README doesn't give any guidance on...