Lee Smith

Results 14 comments of Lee Smith

After `git clone`, you could say run `./bin/setup` and put all that setup stuff in that script. I think that's what it's for.

Isn't this a bit redundant though? Doesn't Devise itself already test all this? I think testing Rails authentication from scratch would be a much better learning experience. And you may...

That makes sense...I didn't realize this project was used for students. Great work! :+1:

To make it easier to keep this lib updated, maybe you should use a gem? https://rubygems.org/gems/pickadate-rails

Figured it out...could have used `RSpec.feature` instead of `RSpec.describe`. Use whichever you prefer.

I'm using phantomJS 2.0.0...as installed via Homebrew for OSX.

I don't guess you were able to replicate this? So for this specific test, when I inspect the params in the create action of the subscriptions controller, "Start date" is...

Is there a reason you're specifically using selenium-webdriver? Doesn't poltergeist run a headless webkit browser in the background? Wouldn't that be preferred over the selenium/firefox combo? This test still fails...

No problem! This is quite a tricky test to accomplish I guess since browsers handle native date inputs differently. I've never had to test that so it's interesting to me....

Looks like I've already fallen victim to this: https://github.com/paweljw/bookstore-backend/pull/6/commits/3e5bf84c62113dcd75d8faaaec6584d776efa244 Whoops. 😜