Thomas J. Leeper

Results 135 comments of Thomas J. Leeper

I think this may have changed at some point, or I never fully built-out the code. We definitely want to bring all of these arguments up into the function signature....

Would love to discuss. I think there are trade-offs here - basically RJava is perpetual pain versus having to basically build a native R SDK - and I can imagine...

Dashboard would be good. But some of these things can be had with bookmarked Github links: - Submissions without an editor: https://github.com/openjournals/joss-reviews/issues?q=is%3Aopen+is%3Aissue+label%3Apre-review+-label%3Apaused+-label%3Awithdrawn+no%3Aassignee - My current papers: https://github.com/openjournals/joss-reviews/issues/assigned/leeper

Thanks for all your work - I'll try to figure out what needs to happen.

I'd say it can be a fully rewrite (or, optionally, an entirely new function). I think it would be nice to have the [`plot.margins()`](https://github.com/leeper/margins/blob/master/R/plot.R) retain some high level arguments (converted...

I didn't implement this mainly because I didn't (and still don't) have time to do it and write the tests needed to make sure it's all correct. If you're keen,...

I think we can just add the whole model object as an attribute. Want to send a PR?

Yes, definite bug. Thanks for reporting!

Thanks, I'll look into this.

- [ ] Fix problem (probably here: https://github.com/leeper/margins/blob/master/R/summary.R#L14-L25) - [ ] Add warning about possible misbehavior - [ ] Note in documentation that variables corresponding to any of those columns...