Junyoung Lee

Results 6 comments of Junyoung Lee

Huh, not sure why my old commits are visible here ...

I have some questions about implementing this w/ ViewModels. > Moving ShowTitleBar...Toggled into the Appearance View Model? I moved the event handler `ShowTitlebarToggled` to the ViewModel and to bind this...

Thanks for the suggestions and approving 😁! But I still have some questions because I'm not seeing the result I want to achieve. Currently, toggling ShowTabsInTitlebar doesn't immediately affect the...

I added a final commit that should complete this! (after [#13869](https://github.com/microsoft/terminal/pull/13839) merges.) It now works beautifully. ![binding](https://user-images.githubusercontent.com/60320918/186551347-f8e2ec7b-4ccf-4175-b8c6-def399d7b64d.gif)

@JohelEGP Unrelated, but how will this code be compiled? ``` same1: type == std::false_type; same1: type == std::true_type; ``` Because ``` template using same1 = std::false_type; template using same1 =...