Lee Byron

Results 160 comments of Lee Byron

Note from live meeting: Merging this _editorial_ change since it accurately describes todays behavior. This merge doesn't close discussion on managing stream error conditions, but will allow us to move...

This would require adding a validation rule that a deprecated object can't be used from a non-deprecated field? Main reason is that introspecting a schema without deprecated values should yield...

Note towards clarifying motivation: Use of fragment spreads of a type is why removing this directly without a deprecation direction is a breaking change and motivates having this tool

Love it! Ship whenever you feel this is ready

I'll likely suggestion continuing this, but while reviewing thought that we might want to consider the next step in removing this "hasValue" concept altogether: https://github.com/graphql/graphql-spec/pull/1178

Following up on this after the discussion in the WG meeting today, my suggestions: 1. Add an appendix section describing the data structure terms we use more specifically along with...

@benjie this change looks good but has some conflicts with the other changes pulled out and recently merged. Want to rebase and fix? Then I'll get this one merged

@benjie I took a pass at some re-ordering of the content here, I'd be curious for your feedback. Also, I think "Grouped Field Set" has become a confusing name. Ideally...

@benjie I made some substantial editorial changes here, especially to one of the term names. Please review!

> I don't know how Lee feels about using _ in fragment names, Would like to keep examples camel case in the spec