Lee Byron
Lee Byron
Context for that comes from the discussions during WG meetings where this proposal moved through the approval stages
Great feedback - I think I've resolved both: * Replaced `fieldName` with `memberName` in the AST to ensure it's generalized between fields, input fields, and enum values. Those are all...
Taking this out of the stack for now. When working on rebasing, I found it not necessarily needed.
Sounds like there's an opportunity for memoization here.
> It might be worth adding an initial _coercedDefaultValue property to the relevant places to help with V8's HiddenClasses. Smart > Can we move the defineArguments refactoring into a separate...
Thanks @andimarek - https://github.com/graphql/graphql-js/issues/3051
Heads up: this diff is about to expand in scope. After spending some time on this today - I'm realizing that #3051 and related comments are actually quite significant and...
Updates in this last commit: - Rewrites default value circular reference checking as "detectDefaultValueCycle()" - Adds test suite for default value circular references - Moves default value validation to utility...
I’m with you in principle but I think we can take a much simpler approach if we can represent defaultValue as an “external input value”, much like variables. We already...
That mostly matches what I'm planning here - I just want to make sure we're clear on terminology because I think `toLiteral` is the wrong idea. Literals are a GraphQL...