Lee Byron

Results 123 comments of Lee Byron

@andimarek - removed `literalToValue` and improved on documentation. Proper schema validation comes in a later PR

This is a good idea. Currently you can emulate it by doing something like: ``` js const queryType = new GraphQLObjectType({ name: 'Query', fields: () => ({ getUser: { type:...

Sorry for the late reply, but I think this is an interesting idea as long as it's optional to not break the existing API.

For those who would like to approach this, consider unfolding one middleware out at a time for PRs rather than one huge PR that attempts to refactor everything at once...

Thanks for everything you've done over the years as a lead maintainer for this most important project. Also, thank you for being proactive about finding a successor! Tapping in @graphql/tsc...

Should we open a dedicated issue to discuss review team change?

Sorry for missing your message above. I think the plan as you outlined it makes sense. Want to include those changes in this PR?

Update on this: master has the type definitions for typescript, but does not yet have them for flow. This is a 1.0-blocker.

Thanks for doing this! Very cool to see the async check implementation out there, that definitely simplifies some things. Some next steps I can see: * Looks like check and...

This is a good argument for pursuing BigDecimal instead of Decimal128, or at the very least support for the proposed behavior of throwing TypeError for use of the `/` operator...