testcheck-js icon indicating copy to clipboard operation
testcheck-js copied to clipboard

Type definitions (typescript & flow) for jasmine-check package

Open vholovko opened this issue 6 years ago • 4 comments

jasmine-check.d.ts cannot be found in the latest distribution 1.0.0-rc.0

untitled

untitled1

untitled1

The library is great but I cannot use it with TypeScript and Jest without first having jasmine-check.d.ts. Please place it in the same root directory as jasmine-check.ts. Thanks!

vholovko avatar Apr 10 '18 14:04 vholovko

Update on this: master has the type definitions for typescript, but does not yet have them for flow. This is a 1.0-blocker.

leebyron avatar Apr 14 '18 16:04 leebyron

Just confirming that the currently published files are missing the typings:

❯ ls node_modules/jasmine-check
LICENSE			README.md		jasmine-check.js	package.json

jasonkuhrt avatar Jun 05 '18 13:06 jasonkuhrt

@leebyron seems like a quickfix, shall I submit a pr or is there more complexity not apparent from this issue?

jasonkuhrt avatar Jun 05 '18 13:06 jasonkuhrt

@jasonkuhrt I'm not @leebyron, but please, submit a PR for this!

sesm avatar Jun 12 '18 13:06 sesm