Levi

Results 56 comments of Levi

> You either need to enable the `http2_prior_knowledge` builder option, or set the builder to use rustls. The default TLS implementation does not use ALPN to negotiate h2 like rustls...

Yep, you're right. This could potentially cause a problem with some servers but isn't an issue on the client side. Closed since not an issue.

I have nothing to add here, but I just wanted to comment that as a beginner to Rust, the usage of this is very confusing. Even as an experienced programmer...

This is also being actively used by PerimeterX. ```js try { e.PX10604 = navigator.plugins.item(4294967296) === navigator.plugins[0]; } catch (e) {} ```

Also just came to thought, I believe `visit_program` (and others) will also not work in unit tests because a `Module` is not a `Program`, as far as I know. So...

Not totally sure if the changed code for array literals is correct -- the code for this is a little more complicated than strings. `[][0]` works correctly for now, but...

Another broken test case: ```javascript var _ = {0.5: 'test'}[0.5]; ``` Currently simplifies to: ```javascript var _ = { 0.5: 'test' }[0.5]; ``` Should simplify to: ```javascript var _ =...

Only one potential issue so far, that `KnownOp` no longer implements `Eq` because of `Index` now taking `f64` instead of `i64`, but seems OK so far to me.

@kdy1 The only remaining issue in terms of code changes is this line. Currently `is_literal(props)` does not work with the unit test below because the `0.5` is not considered a...

I'm pretty sure `Index(f64)` can be changed back to `Index(i64)` as well, as `IndexStr` is always used for objects.