Lukasz Dorau comments

Results 75 comments of


                                            Lukasz Dorau

Add file memory provider

@lplewa all issues fixed, please re-review

Add file memory provider

@lplewa there is still "lplewa requested changes"

Can some memory providers not support the free() operation or not?

See: https://github.com/oneapi-src/unified-memory-framework/pull/773

Can some memory providers not support the free() operation or not?

Fixed by https://github.com/oneapi-src/unified-memory-framework/pull/953

throw() -> noexcept

> @ldorau - I don't think copyright updates really belong in this PR - those should probably be done for the entire project separately. I'm also not sure what you...

Fix coverity issue in the alignToBin

IMHO if Coverity still sees an issue here it should be just marked as a false-positive in Coverity.

Memory leak: `arena_extent_dalloc()` is not called for extents for which `arena_extent_split()` failed

> can you share the path leading to the split hook? Did it reach this function? > The path leading to the split hook: ``` Breakpoint 8, arena_extent_split (extent_hooks=0x7ffff7da6640 ,...

Memory leak: `arena_extent_dalloc()` is not called for extents for which `arena_extent_split()` failed

Hi @interwq I have prepared a reproducer for you: GH branch: https://github.com/ldorau/unified-memory-framework/tree/refs/heads/jemalloc_issue_2815 repro on GHA CI: https://github.com/ldorau/unified-memory-framework/actions/runs/13873571710/job/38823137456 You can clone my repo https://github.com/ldorau/unified-memory-framework/tree/refs/heads/jemalloc_issue_2815 at the [jemalloc_issue_2815](https://github.com/ldorau/unified-memory-framework/tree/refs/heads/jemalloc_issue_2815) branch and reproduce the...

Memory leak: `arena_extent_dalloc()` is not called for extents for which `arena_extent_split()` failed

ping, any updates on this issue?