oneTBB icon indicating copy to clipboard operation
oneTBB copied to clipboard

throw() -> noexcept

Open r-barnes opened this issue 1 year ago • 3 comments

Description

Changes the throw() function qualifier to noexcept. throw() is deprecated/removed as of C++17 and noexcept is present from C++11, so this should be an easy switch to improve compatibility with newer standards

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • [X] bug fix - change that fixes an issue
  • [ ] new feature - change that adds functionality
  • [ ] tests - change in tests
  • [ ] infrastructure - change in infrastructure and CI
  • [ ] documentation - documentation update

Tests

  • [ ] added - required for new features and some bug fixes
  • [X] not needed

Documentation

  • [ ] updated in # - add PR number
  • [ ] needs to be updated
  • [X] not needed

Breaks backward compatibility

  • [ ] Yes
  • [X] No (unlikely)
  • [ ] Unknown

Notify the following users

List users with @ to send notifications

Other information

r-barnes avatar Jun 13 '24 19:06 r-barnes

@ldorau - I don't think copyright updates really belong in this PR - those should probably be done for the entire project separately. I'm also not sure what you mean and wish you'd been specific about what you wanted.

Nonetheless, I've taken a guess at what you wanted and updated the PR accordingly.

r-barnes avatar Jun 24 '24 19:06 r-barnes

@ldorau - I don't think copyright updates really belong in this PR - those should probably be done for the entire project separately. I'm also not sure what you mean and wish you'd been specific about what you wanted.

@r-barnes Copyright updates do really belong to this PR. When you submit a pull request, all CI builds should pass. The copyright_check CI job of your PR was failing: https://github.com/oneapi-src/oneTBB/actions/runs/9505732624/job/26254325125. There are explicitly listed in the log above all copyright dates that should be updated, because you have modified those files.

Nonetheless, I've taken a guess at what you wanted and updated the PR accordingly.

Nonetheless, your guess is correct ;-)

ldorau avatar Jun 26 '24 07:06 ldorau

@KFilipek @lplewa please review

ldorau avatar Jun 26 '24 08:06 ldorau

@KFilipek @lplewa - just checking in on this

r-barnes avatar Jul 16 '24 12:07 r-barnes