Louis DeLosSantos comments

Results 303 comments of


                                            Louis DeLosSantos

Should I expect completion of nested command's flags to work?

@dearchap Unfortunately, your fix does not fix the issue. Like I mentioned above, the replacement of 'args' here: ``` if cmd != nil && cmd.flagSet != nil && cmd.parent !=...

Should I expect completion of nested command's flags to work?

Yes, dont you see the code present in the video I just sent? That is latest.

Should I expect completion of nested command's flags to work?

@dearchap yup, I tried both, both do not complete.

Should I expect completion of nested command's flags to work?

Not for me. Everything works when i comment that out. This, i don't know about positional argument competition. I don't use that only flags

Extend the check-ipsec-leak bpftrace script to capture additional details of leaked packets

Looks great.

daemon: Allow DNS transparent mode to be turned off with encryption

Discussed with @gandro. This seems OK with me as long as the user is aware of the compromises they make when using these features in tandem.

snippet support for mini.completion

awesome!!! I've been waiting for this. I'm trying it out now. Took me a second to realize you enter a 'session' during snippet insert, which I think is a really...

snippet support for mini.completion

Thank you @echasnovski I totally missed that 🤦 I'm playing with the new snippets + completion and its lovely :)

Maintain relative directory in plugins which open buffers

Awesome! Yes I remember certain scenarios with this specific topic being a bit of a pain. Thanks for the effort :)

pkg/k8s: fix hostport service created on incorrect node

@haozhangami looks like consistent failures in: https://github.com/cilium/cilium/actions/runs/10452314004/job/29063749091