Louis DeLosSantos

icon indicating a website link https://who.ldelossa.is icon indicating an email [email protected]

icon company @isovalent icon location NY icon location Software engineer at Isovalent/Cisco focusing on Linux kernel networking, Cilium, and eBPF. Neovim plugin author and Linux Desktop engineer in my spare time.

Results 303 comments of Louis DeLosSantos

xfrm: add rules for encrypt overlay

/test

xfrm: add rules for encrypt overlay

Marking ready to merge. The failing e2e test is a known issue being worked on currently by CI Force.

xfrm: add rules for encrypt overlay

/test

datapath: Add support for skipping direct routes on different L2 networks

Let's pause this PR just for a bit while we discuss this point: https://github.com/cilium/cilium/issues/31124#issuecomment-2148030034 Overall, the PR looks generally harmless and I'm not opposed, but I'd like to square up...

datapath: Add support for skipping direct routes on different L2 networks

@jleeh please run 'make -C Documentation update-cmdref' and push changes back up. That is why the `Documentation Updates / Check generated documentation` CI test is failing.

daemon: Make cilium status independent from k8s status

@tkna I'm going to mark this for more discussion. While I see your issue, I'm not sure if disabling liveliness probes is ideal from Cilium's point of view. I'm going...

pkg/controller: ensure latest controller params are updated

Seemingly related to: https://github.com/cilium/cilium/issues/29015

Should I expect completion of nested command's flags to work?

Hey there @dearchap ``` module github.com/ldelossa/cmds go 1.22.2 require ( github.com/urfave/cli/v3 v3.0.0-alpha9 gopkg.in/yaml.v3 v3.0.1 ) ``` So v3. You can see my code here: https://github.com/ldelossa/cmds/blob/main/main.go#L129 Tho its a bit funky,...

Should I expect completion of nested command's flags to work?

@dearchap Here is a screencap of the issue, as you can see, I can not get tab completion for any flag hanging off the sub command 'automation' https://github.com/urfave/cli/assets/5642902/dddea9f3-3448-473e-bc5e-f66eee0ec02c I'm not...

Should I expect completion of nested command's flags to work?

@dearchap Are you sure I should be seeing completion for flags? ``` ~/go/cmds main* 01:38:11PM 🖳 ./cmds automation rocky-linux --generate-shell-completion ~/go/cmds main* 01:38:26PM 🖳 ./cmds automation --generate-shell-completion rocky-linux:Setup a Rocky...