Lars de Bruijn comments

Results 6 comments of


                                            Lars de Bruijn

Optionally render entity requires populator function for advanced @requires use cases

Hey! I wanted to contribute to this after not following up on the previos PR attempt. I can't seem to add commits to this PR, but I've spend some time...

Optionally render entity requires populator function for advanced @requires use cases

> Hi @ldebruijn. Thanks for working on those tests, I was just starting that when I saw your reply. I'm wondering if we should make a new test tree for...

Optionally render entity requires populator function for advanced @requires use cases

What is left to pull this PR across the finish line?

Optionally render entity requires populator function for advanced @requires use cases

@StevenACoffman don’t get me wrong! I wasn’t insinuating you to be more involved. It was an honest ask for the left over work to get the PR merged. As far...

Optionally render entity requires populator function for advanced @requires use cases

From what I can see this is probably the last bit that is still failing the tests. They fail as they observe changes in the generated `federation.requires.go` file. This is...

Optionally render entity requires populator function for advanced @requires use cases

I've been running it on PRO over the weekend, works perfectly. Adopting the change was a breeze as well. Currently have no suggestions for improvements.