Chi Li

Missing error checks about function time(), gmtime() and strftime()

2

Hi, I notice that funtion time(), gmtime() and strftime() are frequently used in the log.c. Here is an example of the usages, as shown in the following code, function time(),...

Hi, I find that several error handling sites forget to free the resource, which is allocated by function SSL_CTX_new(). See the following code, at line 128, function SSL_CTX_new() allocates the...

Incorrect error check in function ioctl()

2

Hi, Function ioctl() returns -1 on error. There maybe exists an incorrect error check in function ioctl(). See the following code, : https://github.com/rdesktop/rdesktop/blob/a4bdfcfe76b4d39c2d6fd7c8c5be4af90dd4b82d/parallel.c#L159-L162 Also, i check the document of the...

Hi, The _void *realloc(void *ptr, size_t size)_ function changes the size of the memory block pointed to by _ptr_ to size bytes. The realloc() function returns a pointer to the...