Logan Bussell

Results 358 comments of Logan Bussell

Hey @rainersigwald, @BenVillalobos, this will be needed for source-build in 7.0. I was testing this locally before I saw this PR, I am hitting the same issues as the CI...

I pushed the branch I was working on to [here](https://github.com/lbussell/msbuild/commits/net7.0-tfm). The only thing I tried differently was adding nowarn for some of the SYSLIB errors, which gave more errors: [msbuild.txt](https://github.com/dotnet/msbuild/files/9151822/msbuild.txt)

Hi @BenVillalobos, what's the status of this? Can it be merged soon? Thanks!

@rainersigwald Please consider adding the source-build team to the meeting if it's appropriate (myself, @crummel, @MichaelSimons). We were hoping to get this change in for RC2.

@BenVillalobos @rainersigwald @jaredpar, from the discussion we had in the meeting, is the plan now to merge this to flush out any potential issues going forwards?

There isn't a widely used one as far as I know. Maybe some options could be `Ctrl-Q` (for quote), `Ctrl-'`, or `Ctrl-Shift-.` / `Ctrl->`

I'm seeing this error when testing locally: > `/home/logan/vcs/command-line-api/src/System.CommandLine/Binding/ArgumentConverter.DefaultValues.cs(34,20): error IL2070: 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicParameterlessConstructor' in call to 'System.Type.GetConstructor(Type[])'. The parameter 'listType' of method 'System.CommandLine.Binding.ArgumentConverter.CreateEmptyList(Type)' does not have...

@jonsequitur, @brettfo, will these changes flow into SDK and eventually [installer/release/7.0.1xx](https://github.com/dotnet/installer/tree/release/7.0.1xx)? It's been a while since this was merged and usually changes flow by then. If not, then where do...

> I can take care of this for you. Thanks. The change in its current state works for the purposes of source build (unless you notice any functional issues) and...

In newer versions of Docker (including the one in alpine3.18 and our ImageBuilder image), `docker build` is aliased to `docker buildx build` [[source]](https://docs.docker.com/build/architecture/). I assume the intent of this issue...