Ludovico Bianchi

Results 44 comments of Ludovico Bianchi

This could be done as part of the IDAES v2 codebase refactoring/improvements.

The current [Update IDAES paragraph](https://idaes-pse.readthedocs.io/en/stable/tutorials/advanced_install/index.html#update-idaes) is inaccurate (or at least inconsistent with the rest of the document) since it results in a non-editable installation. We should update that part of...

@jghouse88 @adowling2 we're looking at open PRs in preparation for the August release. Is this work expected to be completed in the next few days? Otherwise, we can keep tracking...

> @lbianchi-lbl Do you want us to update the table above if we have comments to make? E.g. `pint` is basically required for all IDAES models through our use of...

@andrewlee94 - thanks for the corrections for `pint`, `networkx`, and `pyyaml`. It seems that these should be part of the core dependencies, also considering that (AFAIK) the payoff from making...

> @lbianchi-lbl I would also suggest that we might also want to have some further "use-case" only dependencies - i.e. things that are only used by one (sub-)package in the...

I've edited the original comment adding a first proposed grouping for the dependencies, as "Option A". Feel free to add your thoughts, either in a comment to the issue or...

@radhakrishnatg @xiangao1 as far as I can understand the failing test is due to `tx_utils` (used for `validate_and_clean_cost_curve()` in `bidder.Bidder._assemble_bids()`) being imported conditionally only if `egret` is installed: https://github.com/xiangao1/idaes-pse/blob/a52b074ab64f15aba073a657576ddd2856de75d0/idaes/apps/grid_integration/bidder.py#L1201-L1216 https://github.com/xiangao1/idaes-pse/blob/a52b074ab64f15aba073a657576ddd2856de75d0/idaes/apps/grid_integration/bidder.py#L22-L24...

Most of the upcoming work on this will be on the documentation (rather than code) side.

@Xinhe-Chen @adowling2 Without knowing more about the current and future plans for OMLT, I'm not personally aware of any strong reason why the specific version 0.3.1 was chosen. My suggestion...