idaes-pse icon indicating copy to clipboard operation
idaes-pse copied to clipboard

Improvements to distillation unit model

Open jghouse88 opened this issue 4 years ago • 9 comments

Pending items:

  • [x] Tray model replacing component temp and press ref
  • [ ] Add support the newer version of the square flash formulation where we removed the need for bubble and dew point
  • [ ] Initialization improvement to include a linear temperature profile before activating energy balance
  • [ ] Add compatibility to scaling framework
  • [x] Add compatibility to generic properties framework
  • [x] Separate out make_phase_split and propagate_state methods as utility methods and use these in condenser and reboiler unit models
  • [ ] Add report() method for column
  • [ ] Check that flowsheet.report() works with distillation columns - there appears to be a bug somewhere.

jghouse88 avatar Nov 22 '20 07:11 jghouse88

@jghouse88 is this still possible for Aug? Is there someone else who could take it over?

ksbeattie avatar Jul 15 '21 18:07 ksbeattie

@agarciadiego Are you using this branch?

adowling2 avatar Jul 16 '21 00:07 adowling2

@jghouse88 @adowling2 we're looking at open PRs in preparation for the August release. Is this work expected to be completed in the next few days? Otherwise, we can keep tracking this PR as part of the November release.

lbianchi-lbl avatar Aug 13 '21 00:08 lbianchi-lbl

Check that flowsheet.report() works with distillation columns - there appears to be a bug somewhere.

Found the cause of this while investigating #480. The UnitModelBlock.add_inlet_port() method currently adds an additional _state_block attribute to a port while generating it. That attaches the state_block to the feed tray's port, but because the attribute is not one added by Pyomo, it isn't copied when the port is extended to the level of the overall column. We are currently figuring out a better method to make stream information available, but the distillation column is not at fault for this.

The condenser.distillate and reboiler.bottoms ports should be extended to the column level as well. Otherwise Pyomo's SequentialDecomposition tool will get confused when trying to build a graph of the flowsheet and won't record that arcs attached to those ports are attached to the distillation column.

dallan-keylogic avatar Aug 27 '21 19:08 dallan-keylogic

@jghouse88, seems like this should get a new assignee. Can you pick one?

ksbeattie avatar May 19 '22 18:05 ksbeattie

@jghouse88 is this still relevant?

ksbeattie avatar Aug 04 '22 18:08 ksbeattie

@ksbeattie It is still very relevant, but we lack the resources to address it right now.

andrewlee94 avatar Aug 04 '22 19:08 andrewlee94

@agarciadiego has been working on extensions of this. We have ideas on improving initialization. But our work has been exploratory. It is far from generalized.

adowling2 avatar Aug 04 '22 22:08 adowling2

I was thinking @agarciadiego would be a good person to take this over, however he probably won;t have time in the next few months as I believe he is committed to other projects.

andrewlee94 avatar Aug 18 '22 19:08 andrewlee94