LB (Ben Johnston)

icon indicating a website link https://lb.ee icon indicating an email [email protected]

icon company Virgin Australia icon location Brisbane, Australia icon location LB (pronounced ‘Albi’), love coffee, systems, travel, technology and also coffee. Incredibly thankful for my amazing wife Bec and son Leo.

Results 1054 comments of LB (Ben Johnston)

General styling improvements

Partial progress on this has been merged via #11097 1. Listing background/border changes 2. Combobox (block chooser) padding 3. Accounts settings panels padding

Retain fields parameter when redirecting from find_view of API

@ahosgood - are you able to add a unit test for this?

Retain fields parameter when redirecting from find_view of API

Thanks @ahosgood I've triggered the CI.

Prevent loss of WIP changes by accidentally closing modals

An idea, with our Stimulus dialog code, we could add a change listener. If any change event bubbles from inside we know outside click should not close the modal. We...

Prevent loss of WIP changes by accidentally closing modals

@thibaudcolas - would love some of your input here. Some options for a way forward. 1. Just change all modals to stop outside clicks 2. Stop outside clicks if we...

Refactor UnsavedController to Use event.preventDefault() for Browser Confirmation Dialog

Thank you @shubhammukati I have referenced you in the changelog via the merged PR #12311 that included this PR. I have added you to the contributors list as `Shubham Mukati`,...

Bugfix: Closed opened files as a coding standard

Thank you for the review @RealOrangeOne & thanks @fazledyn for responding to feedback. We have merged this in and I have added you to the contributors list as 'Ataf Fazledin...

Image focal points aren't updated when saved

Does updating the image renditions make any difference? https://docs.wagtail.org/en/latest/reference/management_commands.html#wagtail-update-image-renditions ``` ./manage.py wagtail_update_image_renditions ```

Image focal points aren't updated when saved

Yep. That's fair.

[meta] package.json - Update Jest & jscodeshift

Thanks @ljharb I have confirmed I can run the two following scripts before and after the jscodeshift update without triggering any diffs in my local changes. ``` npm run create...