LB (Ben Johnston)

Results 1054 comments of LB (Ben Johnston)

Thank you @laymonage - this area is not really my expertise but I'm excited to see something more flexible and central come in to Wagtail. I don't have any strong...

This might need to move to the wagtail.org repo - looks like a similar issue was fixed there previously. https://github.com/wagtail/wagtail.org/issues/223

Moved from Wagtail repo - however, I cannot reproduce this after a quick smoke test, running the following in the browser works fine. It must be something to do with...

OK it looks like every PR is failing unless I add and remove that cache clearing commit, somewhat annoying.

Just saying I think this is a nice approach, I haven't run the code locally though but a bit more flexibility but also avoiding hard-coding links as buttons is helpful....

I think this is the code that handles this in the jQuery UI one. https://github.com/jackmoore/autosize/blob/master/src/autosize.js#L86

@29deepanshutyagi here's a good starting point for a Stimulus implementation of this feature. https://github.com/stimulus-components/stimulus-password-visibility/blob/master/src/index.ts I'd recommend we add this capability to the the [ActionController](https://github.com/wagtail/wagtail/blob/5f158de94a8e16a7e7bea0795d0704c2ba5e2f94/client/src/controllers/ActionController.ts#L50). Maybe we should have a separate...

@zerolab - I'll try to merge this. @saevarom - let us know if you want to hold until you have reviewed also.