LB (Ben Johnston)

Results 1054 comments of LB (Ben Johnston)

@zerolab @thibaudcolas (or others) this PR has been updated as per the discussion to use the `w-rules` naming. I have tested these changes and they work reliably on the image...

@thibaudcolas - please can you keep this on your radar for reviews. This code has been validated by Dan but needs your or maybe @laymonage to check you are happy...

Thank you @laymonage - I'll get onto this when I can. Great feedback, I'll look into the superset thing and check if there's another approach or a polyfill. Good call...

Adding a link to the issue on Wagtail that relates to this. https://github.com/wagtail/wagtail/issues/10816

See also a fix for wrapping content in comment replies - linking for reference only. https://github.com/wagtail/wagtail/issues/11324 https://github.com/wagtail/wagtail/pull/11325

@nandini584 this issue is assigned to members of the core team so I assume they will be resolved by theem. However, if you're up for it, could you try to...

@Chiemezuo do you mind changing this to a draft PR while it's still a WIP?

My apologies, I should have read all the comments. If it's close to review then, maybe just update the title to not have the 'work in progress'.

Just cross-linking to https://github.com/wagtail/wagtail/issues/10168 - while this is related to the underlying JS behaviour it's good to be aware of this.

Have a look at the original PR that implemented most of this @zayed-haque https://github.com/wagtail/wagtail/pull/8386/files#diff-d6bcadd55a2bdf7c24ac2bd2ee5186fb90937a7181207e115d193c5e5765e755R58 I believe it was solved there and used an approach that DRF uses for a similar...