LB (Ben Johnston)
LB (Ben Johnston)
@bbeniamin I have added you to the contributors list as `Beniamin Bucur` - let me know if you want a different name listed. Thanks again for taking the time to...
> > @tomdyson should I raise a new issue for that additional edge case? > > I think so, yes please @lb-. Unless the quote type gets normalised further up...
Squashed, rebased, added release notes and will merge in. I will merge this into 5.2 though as we did not merge before the RC, unless there is push back on...
@Lovelyfin00 is this ready for a review or feedback? Looks like one of the unit tests is failing
Note: we could probably use Fetch here instead of XMLHttprequest
Flagging as needs design decision. Maybe we should formally support the empty list as the preferred way to disable searching. We do something similar for preview modes. Additionally, having an...
have flagged in core team chat - will see if I can get another opinion or two on this one. I personally think `search_fields = []` as the way to...
@dkirkham - we spoke about this at the core team and have a plan for how to move forward with this. Please let us know if you are still ok...
@dkirkham from memory - the reasoning for ten was pretty arbitrary, it's not meant to be exhaustive and as per the comment was only meant to flag the potential issue....
Thanks. Have self requested a review