LB (Ben Johnston)
LB (Ben Johnston)
@Tijani-Dia what about `EditView` ``` from wagtail.admin.views.generic import EditView ``` See usage examples here * wagtail/admin/views/collections.py * wagtail/admin/views/workflows.py * wagtail/users/views/users.py (most recent adoption) We are slowly trying to move to...
Thanks @Tijani-Dia I've self-requested a review and will try to take a look soon
@zerolab ok - I must have missed that - I did check the local build and saw that the method was added correctly (on single and multi-site). I will leave...
Go for it @yokwejuste Start by getting the pattern library (Storybook) running locally to reproduce the issue and try to debug it. Here are the instructions. https://docs.wagtail.org/en/latest/contributing/developing.html#using-the-pattern-library It assumes you...
@activus-d see also the code conflicts - these will need to be resolved.
Ok thanks Matt. I missed that convo.
Similar PR with overlapping changes has also come in. https://github.com/wagtail/wagtail/pull/9329
Agreed, I have had to get the request with a work around when we have wanted to do some request specific userbar changes.
Proposed solution for this is to pass `page` as a third arg to the hook, as we are already pulling `request` from `context we do not really want to pass...
Note. It appears that this may have some similar changes to a PR already up. https://github.com/wagtail/wagtail/pull/9373 @zobbs-git can you take a look at that PR - maybe remove any duplicate...