LB (Ben Johnston) comments

Results 1054 comments of


                                            LB (Ben Johnston)

Documentation - pagination improvements

I have put some feedback on the PR but just adding some solution ideas here, but the general gist is that we probably should tackle this in two parts. A....

Broken dashboard JS due to notifier’s version processing failing for nightly release versions

Confirmed

Broken dashboard JS due to notifier’s version processing failing for nightly release versions

I think it's ok to update our JS. We can just not throw and error in this case - and no need to try to match the versions to try...

Ensure MultiFieldPanel outputs all child classnames

Cherry picked to 4.0 stable b81dfbbe96ef130297bc041304fea550af4af066

feat: customize package details with environment variables

Flagging for discussion at core team - thanks for the PR @dopry - not sure if this needs deeper discussion so just added the label needs design decision for now.

feat: customize package details with environment variables

Spoke about this at core team - there may be some tweaks needed for this with naming - but this is generally supported. For example `WAGTAIL_SETUPPY_NAME` kind of reads a...

feat: use Willow instead of Pillow for images.

> @lb- I rebased today to keep the branch fresh. Are there any maintainers in particular who I should reach out to in order to get this reviewed? At the...

feat: use Willow instead of Pillow for images.

Thanks for the ping @dopry - I'll flag in the core team chat but for now just needs to wait for someone to review. Not sure who is the best...

Document how to add Collections as Foreign Key to a Page

https://docs.wagtail.org/en/stable/reference/pages/model_recipes.html Would be a good home for this

feat: allow ImageField form override

Would it be possible to also add a unit test that covers the override/extend scenario so that it doesn't break in the future.