Lázaro Clapp comments

Results 76 comments of


                                            Lázaro Clapp

Null propagation doesn't work between Java Stream operations

So, the places to look at for stream handling are: - [StreamNullabilityPropagatorFactory](https://github.com/uber/NullAway/blob/master/nullaway/src/main/java/com/uber/nullaway/handlers/StreamNullabilityPropagatorFactory.java): Defines different stream APIs (e.g. Java 8 streams vs Rx) in a high-level declarative manner. - [StreamNullabilityPropagator](https://github.com/uber/NullAway/blob/master/nullaway/src/main/java/com/uber/nullaway/handlers/StreamNullabilityPropagator.java): The...

Null propagation doesn't work between Java Stream operations

> > It might be possible to extend the stream handler to also propagate facts belonging to the shared closure of all lambdas in the stream, but I am not...

Null propagation doesn't work between Java Stream operations

> Regarding calls to `map.remove()`, we are already unsound for such calls even ignoring streams :-) Fair. I don't quite remember the semantics of `remove()` on existing APs involving that...

Error reported by incorrect association between two method invocations

(As a note: might want to revise the last few PRs and the error messages, because the chain above has some inaccurate strings, e.g. the duplicated "read from result 0...

Nil Detection when inject some dependency to other package

I believe this falls within struct initialization, which is a feature we are working to enable more broadly 🙂 Basically, right now, NilAway will complain if there is an explicit...

False positive in checking nilabilty of slice using `len(s)` assigned to a variable

> > However, if `len(slice) - 1 >= 0`, then `len(slice) > 0` so it should infer that the slice is non-nil. > Just to set expectations a bit here,...