Lázaro Clapp

Results 76 comments of Lázaro Clapp

NullAway maintainer here. This definitely is already in our radar (cross-ref: https://github.com/uber/NullAway/issues/628, cc: @msridhar) It appears that in all cases where `@Nullable` is being removed, a new `@ParametricNullness` annotation is...

> One question to help me understand the scope of the problem: Are you setting the `AnnotatedPackages` (sometimes set under the differently cased name "`annotatedPackages`") flag to cover `com.google.common`? For...

> If NullAway does ~~someday~~ _today_ recognize `@ParametricNullness` [...] 😉 In all fairness, that's on master branch right now. We are aiming to cut a release before the end of...

So, reading this discussion, it sounds to me like: - In the absence of proper handling of type parameter nullness, NullAway resolving `@ParametricNullness` to `@Nullable` is _correct_/_sound_, even for the...

> Limitations: > > * This does not remove unused imports for the test methods because we > have to account for cases of the test methods that will not...

Mostly replying here for visibility, but Adell and I discussed this offline and the best way to proceed seems to be for them to work over a fork of Piranha...

Keep in mind that `-XepExcludedPaths` will also exclude everything from being processed by Piranha. `-XepDisableAllChecks` is what you most likely want, if you are not otherwise using Error Prone, followed...

Note: I think the above should be ``` someConsumer.accept((x) -> doSomething(x)); ``` without the extra semicolon. Also, you don't need the parenthesis around the lambda argument for the single argument...

This is not a list of treatment groups, but of common group names. Meaning cases where it's counterproductive for Piranha to use the treatment condition name to decide what to...

So, I definitely don't mind having a compact, semi-formal, non-context-dependent (e.g. `@NullMarked` vs `@NullUnmarked` code) way of expressing nullability of types. For that use, I am not sure I feel...