Lázaro Clapp

Results 80 comments of Lázaro Clapp

> The "consistency" I keep referring to was meant to only cover "when a shorthand is desired, can we use a consistent one". I think, anyway, that it will be...

So, separate from whether we will use it in error messages: I wouldn't hate either `T` or `T!`, but I think `T!` _might_ be clearer for something that is a...

As a note, the way NullAway handles this is to support a subset of JetBrains's `@Contract` [annotations](https://www.jetbrains.com/help/idea/contract-annotations.html). In particular: ``` @Contract("null -> fail") public Object checkNotNull(@Nullable Object o) {...} ```...

If this is two separate questions: a) Should there be a JSpecify mechanism to mark a method as throwing an exception when passed `null`, even though `@Nullable` is the accepted...

> > Note: This PR can wait until the next release of NullAway (0.10.2). > > Do you mean until _after_ that release? For context, we want to have a...

Hi @marc-szalkiewicz-dd, at a glance, and after taking a look at `org.immutables`, this looks very similar to the EP/Lombok compatibility issues, where one tool modifies the AST in memory during...

That makes sense from a soundness perspective, of course: every method called might thrown an unchecked exception that could need to be propagated out of that method. On the other...

> If we are not gaining much information from the try block which can potentially throw a caught NPE. We can remove that block from the bytecode in the pre-processing...

There was some discussion on https://github.com/google/guava/issues/6126 about changing the meta-annotation for `@ParametricNullness` from `@javax.annotation.Nonnull` to `@javax.annotation.Nullable`. But, until/unless that is done, supporting the general mechanism doesn't actually help us parse...

That's interesting. I think from the NullAway standpoint, I wasn't even thinking of the subtleties of `UNKNOWN` vs `MAYBE`, but rather that there is two ways to interpret `@javax.annotation.Nonnull(when =...